🐛 fix: kustomize problem in e2e #5167
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
needs-priority
size/L
|
/test ? |
|
@richardcase: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
the e2e will fail still but it should progress further (and fail on the AMI): /test pull-cluster-api-provider-aws-e2e |
richardcase
force-pushed
the
e2e_kustomize_fix
branch
from
8f61f1c to
4fcc2c7
Compare
When running the e2e tests after bumping capi to v1.8.x there is an issue with the e2e tests when we setup the manifests to use for the tests. A package we import from the upstream test framework had been updated to use kustomize v5 format. We where still using v4. Also, there is a bug in the upstream package and so we have included the package directly with the fix until its merged upstream. Signed-off-by: Richard Case <[email protected]>
richardcase
force-pushed
the
e2e_kustomize_fix
branch
from
4fcc2c7 to
b812b70
Compare
|
/test pull-cluster-api-provider-aws-e2e |
k8s-ci-robot
added
size/XL
|
/test pull-cluster-api-provider-aws-e2e |
richardcase
force-pushed
the
e2e_kustomize_fix
branch
from
44f630b to
b812b70
Compare
k8s-ci-robot
added
size/L
After upgrading to kustomization v5 we need to make some updates to our kustomization files. Signed-off-by: Richard Case <[email protected]>
k8s-ci-robot
added
size/XL
|
/test pull-cluster-api-provider-aws-e2e |
1 similar comment
|
/test pull-cluster-api-provider-aws-e2e |
|
@richardcase: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Excellent, the e2e is failing on getting the AMI as expected: I'd like to get this merged if possible. We'll need to follow up on updating the rest of the kustomization.yaml files. |
| @@ -37,9 +37,9 @@ import ( | |||
| . "github.com/onsi/gomega" | |||
| "sigs.k8s.io/yaml" | |||
|
|
|||
| "sigs.k8s.io/cluster-api-provider-aws/v2/test/helpers/kubernetesversions" | |||
There was a problem hiding this comment.
We could add a comment here saying this is a temporary workaround until a new CAPI v1.8.5 with kubernetes-sigs/cluster-api#11307 included
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind bug
What this PR does / why we need it:
When running the e2e tests after bumping capi to v1.8.x there is an issue with the e2e tests when we setup the manifests to use for the tests. A package we import from the upstream test framework had been updated to use kustomize v5 format. We where still using v4.
Also, there is a bug in the upstream package and so we have included the package directly with the fix until its merged upstream.
Thanks @damdo for help with this.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #5165
Special notes for your reviewer:
Upstream issue: kubernetes-sigs/cluster-api#11305
Checklist:
Release note: